Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bedrock Converse reports cache-read and cache-write tokens separately from
inputTokens. APISIX currently omits these tokens from normalized prompt usage and reports zero for both cache counters, affecting token accounting and LLM logs in streaming and non-streaming responses.For example, a response with 10 input tokens, 20 cache-read tokens, 30 cache-write tokens, and 8 output tokens should report 60 prompt tokens, rather than 10.
Changes
Use the same usage normalization for ordinary responses and streaming metadata:
prompt_tokens, and expose both cache counters to the existing LLM logging variables.totalTokenswhen present; otherwise, calculate the total from normalized prompt and completion tokens.cacheReadInputTokenCountandcacheWriteInputTokenCountaliases. Prefer the canonical Converse fields, including explicit zero values.The prompt-token calculation follows the AWS prompt caching documentation:
LiteLLM uses the same calculation in
AmazonConverseConfig.transform_usage, lines 2339–2344:It then assigns
input_tokenstoUsage.prompt_tokens. Alias precedence follows its separate cache-count helpers.Tests
3d526bfe: all 120 comparisons across 12 cases and two response modes match.Validation recorded when preparing this change: all 65 assertions in
t/plugin/ai-proxy-bedrock-single.tpassed, andluacheckreported no warnings or errors for the changed Lua code.Checklist